I'm currently editing RabidXDog's War of the 5 Kings map.

I've changed the terrain, converted countdown timer/wait triggers into death counters, changed many 'player brings' into 'player commands' conditions, and am implementing hyper triggers.

Starting the map with 7 comp players the trigger lag is quite bad. I've tried going through and deleting chunks of triggers at a time to figure out where the hold up is coming from but I haven't found a smoking gun. It seems like the more triggers I delete the faster it gets but it's difficult to tell whats going on by just eyeballing it.

I'd appreciate any help figuring this out, thanks.

edit: uploaded new version of the map, where I edited many triggers for speed, a tad bit faster but still major lag

Attachments:

Post has been edited 1 time(s), last time on Jun 30 2015, 5:52 pm by sigsaucy.

I solved the problem. I'm noot sure if it was one thing that I fixed or just an accumulation but its fixed.

I moved as many triggers from all players over to a computer player and replaced the original city capture triggers


Trigger("All players"){
Conditions:
Bring("Current Player", "Terran Civilian", "City 1 (1)", At least, 1);
Bring("Foes", "Terran Civilian", "City 1 (1)", At most, 0);
Bring("Foes", "Protoss Photon Cannon", "City 1 (1)", At most, 0);
Bring("Foes", "Terran Bunker", "City 1 (1)", At most, 0);
Bring("Foes", "Men", "City 1 (1)", At most, 0);
Bring("Allies", "Terran Civilian", "City 1 (1)", At most, 0);
Bring("Allies", "Protoss Photon Cannon", "City 1 (1)", At most, 0);
Bring("Non Allied Victory Players", "Protoss Photon Cannon", "City 1 (1)", At most, 0);
Bring("Non Allied Victory Players", "Terran Civilian", "City 1 (1)", At most, 0);

Actions:
Give Units to Player("All players", "Current Player", "Buildings", All, "City 1 (1)");
Preserve Trigger();
Comment("City Capture Triggers");
}


with

Trigger("All players"){
Conditions:
Bring("Current Player", "Men", "City 1", At least, 6);
Bring("Foes", "Men", "City 1", At most, 0);
Bring("Foes", "Protoss Photon Cannon", "City 1", At most, 0);
Bring("Foes", "Buildings", "City 1", At least, 1);

Actions:
Give Units to Player("All players", "Current Player", "Buildings", All, "City 1");
Preserve Trigger();
Comment("CAPTURE city 1");
}



since there were 100 cities, i think cutting down the number of conditions really helped.

From what I know this shouldn't be the source of the lag. What happens is when SC checks for the first bring condidion at location "City 1 (1)" it's contents are being cached causing all subsequent checks cost minimal processor time. A rule of thumb that I use: subsequent bring condition tests on a single location cost approximately as much as a single bring condition test.

As far as I remember create unit action isn't invalidating cache causing the new unit invisible in subsequent triggers checks. Consider the following example:



Player will see a message "Unit U isn't here!" followed by "Unit U is here!" as expected, but if you omit Trigger 1 or Trigger 3 the player will receive double "Unit U isn't here!", because L is precached in Trigger 1 and cache isn't invalidated when Trigger 2 creates unit, then Trigger 4 uses this invalid cache data from Trigger 1 instead of repopulating the cache with the new contents of the location L.