I have a trigger to create units based on a code entered using civs(golems) but when the unit is spawned at a holding area the next trigger is to move that unit from the holding location to a new location by the current players base. But the trigger isnt working.

Trigger looks like this

for player 1
always
move all units at holding zone for player 1 to player 1 hero

Whats the problem?

Is there a preserve trigger action for it? If not you need to add it.

ive always seen the preserve trigger actions but never understood the use...i will add it but could someone explain preserve trigger to me, a new map builder.

Having "Preserve Trigger" anywhere in the actions section of the trigger will make the trigger continue running throughout the game, so long as the conditions are met. Without it, the trigger will only ever run once.

My question, what is the point of having a holding area? Why not just create them directly where they need to be, and if you're trying to avoid creation error messages, which are definitely a problem in Golem maps, why don't you just create it and move it in the same trigger?

It saves code doing the holding area because I am working off of a shell i made about 3 years ago. Ive gotten better at understanding triggers and map making and decided to try again. The shell had only the her golem codes done so i decided to add to it and make them spawn at the bases as opposed to how i originally had it where they spawned at a communal spot.

Kaias got it right, but I want to give a little background on the "preserve trigger":
Normally all triggers run once (when the conditions are met), and then are deleted from memory.
To prevent sc from deleting a trigger there's the "preserve trigger" action. It doesn't do anything in your map but telling sc not to delete, but preserve the trigger.

Welcome messages are obvious examples for non-preserved triggers,
Spawning triggers are examples that need the preserve trigger.