Hi, I'm attempting to make a Total War style map with city taking over that goes like

-bring men to enemy city
-enemy spawns units
-once all enemy dead around city you get control of it

The issue i'm having is that cities are spawning units twice, once when you initially bring your units, and again when you take the city.

You can run the attached map to see what im talking about.

I think the error has something to do with switches.

Thanks, here are the triggers




CITY SPAWN TRIGGER

Trigger("Player 1","Player 2","Player 3","Player 4","Player 5","Player 6","Player 7","Player 8"){
Conditions:
Switch("Switch1", not set);
Bring("Current Player", "Terran Supply Depot", "1", Exactly, 1);
Bring("Foes", "Men", "1", At least, 1);

Actions:
Set Switch("Switch1", set);
Create Unit("Current Player", "Tassadar (Templar)", 3, "1");
Modify Unit Hit Points("Current Player", "Terran Supply Depot", 50, 0, "1");
Display Text Message(Always Display, "Under Attack");
Minimap Ping("1");
Minimap Ping("1");
Preserve Trigger();
Comment("1 spawn");
}



CITY CAPTURE TRIGGER
//-----------------------------------------------------------------//

Trigger("Player 1","Player 2","Player 3","Player 4","Player 5","Player 6","Player 7","Player 8"){
Conditions:
Bring("Foes", "Terran Supply Depot", "1", At least, 1);
Bring("Foes", "Men", "1", Exactly, 0);
Bring("Current Player", "Men", "1", At least, 1);
Switch("Switch1", set);

Actions:
Give Units to Player("Foes", "Current Player", "Terran Supply Depot", All, "1");
Modify Unit Hit Points("All players", "Terran Supply Depot", 100, 0, "1");
Display Text Message(Always Display, "We have taken this city");
Preserve Trigger();
Comment("1 capture");
Set Switch("Switch1", clear);
}




CITY DEFENDED TRIGGER
//-----------------------------------------------------------------//

Trigger("Player 1","Player 2","Player 3","Player 4","Player 5","Player 6","Player 7","Player 8"){
Conditions:
Bring("Foes", "Men", "1", Exactly, 0);
Bring("Current Player", "Terran Supply Depot", "1", At least, 1);
Switch("Switch1", set);

Actions:
Remove Unit At Location("Current Player", "Tassadar (Templar)", All, "1");
Modify Unit Hit Points("All players", "Terran Supply Depot", 100, 0, "1");
Set Switch("Switch1", clear);
Preserve Trigger();
Comment("1 defended");
}

//-----------------------------------------------------------------//

Attachments:

I found the bug. There was nothing wrong with your triggers but the thing that was causing the units to spawn twice was a bring condition bug. Starcraft sometimes does not update correctly between triggers and the "Bring" condition will return true when we know it to be false. http://www.staredit.net/starcraft/Bring_Condition_Bug. It thought that player 8 still had a depot there when it did not therefore it spawned the units twice. I put in a move location action to force starcraft to update correctly between the triggers.

Attachments:

Thanks! that fixed it.

Although the link you sent said "Remove 1 Map Revealer for Player at Location" is the best trigger to use to refresh locations due to not doing anything.

Is there any reason I should use a move location trigger instead of this? Is one of these faster or more efficient to use?

There will be alot of triggers (around 200 cities) which is why i want the best one.

Most people consider the 255 location limit to be very extreme should you use gridding systems but assuming this is not a concern we can do some comparison...

In both I assume the unit ID is not present.

Move location: src location, unit, player, dest location (note that this always moves the location regardless of whether the dest unit is found)
    1. Find unit at dest location (at best, binary tree search of pre-compiled data)
    2. Change location coordinates (4 values)
    3. Validate location coordinates (4 comparisons)
    4. Refresh location data

Remove unit at location: amount, unit, player, location
    1. Find unit at location (at best, binary tree search or pre-compiled data)
    2. (remove nothing)
    3. Refresh location data

Remove unit at location for a unit that does not exist should be slightly better.

But not necessarily, since grid systems are very limited and aren't perfected. There is a system that would completely eliminate the need for locations in most applications, but it has not yet been documented (I'm working on it). The truth is that most sc1 documentation isn't very complete and thorough.