I have separate triggers set for each player, but they only seem to work for Player 1 (although I've only tried this with Players 1 & 2)
Any reason why this could happen?
None.
Staredit Network > Forums > SC1 UMS Mapmaking Assistance > Topic: [SOLVED] Triggers not working for some Players
[SOLVED] Triggers not working for some Players
I have it set so that when Player X owns Y amount of Refineries he gains Z amount of Minerals per turn
I have separate triggers set for each player, but they only seem to work for Player 1 (although I've only tried this with Players 1 & 2)
Any reason why this could happen?
I have separate triggers set for each player, but they only seem to work for Player 1 (although I've only tried this with Players 1 & 2)
Any reason why this could happen?
You have an error in your triggers. I don't know if we can help you unless you post your triggers and/or your map.
None.
Quote from 
Vrael
VraelYou have an error in your triggers. I don't know if we can help you unless you post your triggers and/or your map.
whops meant to upload map with the post
its in this one
Attachments:
None.
The first thing I noticed was that:
Could have been replaced with:
Aside from that I see no actual problems with the trigger itself. Are you sure that players 2-6 actually own refineries when the countdown timer reaches 0?
Code
//-----------------------------------------------------------------//
Trigger("Player 2"){
Conditions:
Command("Current Player", "Terran Refinery", Exactly, 1);
Countdown Timer(Exactly, 0);
Actions:
Set Resources("Current Player", Add, 500, ore);
Display Text Message(Always Display, "\x0061\x007 Oil Refinery\x002+500 Minerals");
Comment("1 Refinery");
Preserve Trigger();
}
//-----------------------------------------------------------------//
Trigger("Player 1"){
Conditions:
Command("Current Player", "Terran Refinery", Exactly, 1);
Countdown Timer(Exactly, 0);
Actions:
Set Resources("Current Player", Add, 500, ore);
Display Text Message(Always Display, "\x0061\x007 Oil Refinery\x002+500 Minerals");
Comment("1 Refinery");
Preserve Trigger();
}
//-----------------------------------------------------------------//
Trigger("Player 3"){
Conditions:
Command("Current Player", "Terran Refinery", Exactly, 1);
Countdown Timer(Exactly, 0);
Actions:
Set Resources("Current Player", Add, 500, ore);
Display Text Message(Always Display, "\x0061\x007 Oil Refinery\x002+500 Minerals");
Comment("1 Refinery");
Preserve Trigger();
}
//-----------------------------------------------------------------//
Trigger("Player 4"){
Conditions:
Command("Current Player", "Terran Refinery", Exactly, 1);
Countdown Timer(Exactly, 0);
Actions:
Set Resources("Current Player", Add, 500, ore);
Display Text Message(Always Display, "\x0061\x007 Oil Refinery\x002+500 Minerals");
Comment("1 Refinery");
Preserve Trigger();
}
//-----------------------------------------------------------------//
Trigger("Player 5"){
Conditions:
Command("Current Player", "Terran Refinery", Exactly, 1);
Countdown Timer(Exactly, 0);
Actions:
Set Resources("Current Player", Add, 500, ore);
Display Text Message(Always Display, "\x0061\x007 Oil Refinery\x002+500 Minerals");
Comment("1 Refinery");
Preserve Trigger();
}
//-----------------------------------------------------------------//
Trigger("Player 6"){
Conditions:
Command("Current Player", "Terran Refinery", Exactly, 1);
Countdown Timer(Exactly, 0);
Actions:
Set Resources("Current Player", Add, 500, ore);
Display Text Message(Always Display, "\x0061\x007 Oil Refinery\x002+500 Minerals");
Comment("1 Refinery");
Preserve Trigger();
}
//-----------------------------------------------------------------//
Trigger("Player 2"){
Conditions:
Command("Current Player", "Terran Refinery", Exactly, 1);
Countdown Timer(Exactly, 0);
Actions:
Set Resources("Current Player", Add, 500, ore);
Display Text Message(Always Display, "\x0061\x007 Oil Refinery\x002+500 Minerals");
Comment("1 Refinery");
Preserve Trigger();
}
//-----------------------------------------------------------------//
Trigger("Player 1"){
Conditions:
Command("Current Player", "Terran Refinery", Exactly, 1);
Countdown Timer(Exactly, 0);
Actions:
Set Resources("Current Player", Add, 500, ore);
Display Text Message(Always Display, "\x0061\x007 Oil Refinery\x002+500 Minerals");
Comment("1 Refinery");
Preserve Trigger();
}
//-----------------------------------------------------------------//
Trigger("Player 3"){
Conditions:
Command("Current Player", "Terran Refinery", Exactly, 1);
Countdown Timer(Exactly, 0);
Actions:
Set Resources("Current Player", Add, 500, ore);
Display Text Message(Always Display, "\x0061\x007 Oil Refinery\x002+500 Minerals");
Comment("1 Refinery");
Preserve Trigger();
}
//-----------------------------------------------------------------//
Trigger("Player 4"){
Conditions:
Command("Current Player", "Terran Refinery", Exactly, 1);
Countdown Timer(Exactly, 0);
Actions:
Set Resources("Current Player", Add, 500, ore);
Display Text Message(Always Display, "\x0061\x007 Oil Refinery\x002+500 Minerals");
Comment("1 Refinery");
Preserve Trigger();
}
//-----------------------------------------------------------------//
Trigger("Player 5"){
Conditions:
Command("Current Player", "Terran Refinery", Exactly, 1);
Countdown Timer(Exactly, 0);
Actions:
Set Resources("Current Player", Add, 500, ore);
Display Text Message(Always Display, "\x0061\x007 Oil Refinery\x002+500 Minerals");
Comment("1 Refinery");
Preserve Trigger();
}
//-----------------------------------------------------------------//
Trigger("Player 6"){
Conditions:
Command("Current Player", "Terran Refinery", Exactly, 1);
Countdown Timer(Exactly, 0);
Actions:
Set Resources("Current Player", Add, 500, ore);
Display Text Message(Always Display, "\x0061\x007 Oil Refinery\x002+500 Minerals");
Comment("1 Refinery");
Preserve Trigger();
}
//-----------------------------------------------------------------//
Could have been replaced with:
Code
//-----------------------------------------------------------------//
Trigger("Player 1","Player 2","Player 3","Player 4","Player 5","Player 6"){
Conditions:
Command("Current Player", "Terran Refinery", Exactly, 1);
Countdown Timer(Exactly, 0);
Actions:
Set Resources("Current Player", Add, 500, ore);
Display Text Message(Always Display, "\x0061\x007 Oil Refinery\x002+500 Minerals");
Comment("1 Refinery");
Preserve Trigger();
}
//-----------------------------------------------------------------//
Trigger("Player 1","Player 2","Player 3","Player 4","Player 5","Player 6"){
Conditions:
Command("Current Player", "Terran Refinery", Exactly, 1);
Countdown Timer(Exactly, 0);
Actions:
Set Resources("Current Player", Add, 500, ore);
Display Text Message(Always Display, "\x0061\x007 Oil Refinery\x002+500 Minerals");
Comment("1 Refinery");
Preserve Trigger();
}
//-----------------------------------------------------------------//
Aside from that I see no actual problems with the trigger itself. Are you sure that players 2-6 actually own refineries when the countdown timer reaches 0?
None.
An artist's depiction of an Extended Unit Death
The issue is that you are resetting the timer under "All Players." If you understand how trigger order works, you'd see the problem with this.
Player 1's refinery trigger runs, and then Player 1 also runs the trigger to reset the timer. Since the timer is no longer at 0, players 2-6 do not get their refinery trigger to execute.
Change the owner of the Timer trigger from "All Players" to "Player 8" (assuming player 8 is a computer player).
Post has been edited 1 time(s), last time on Aug 6 2011, 5:13 am by Roy.
Player 1's refinery trigger runs, and then Player 1 also runs the trigger to reset the timer. Since the timer is no longer at 0, players 2-6 do not get their refinery trigger to execute.
Change the owner of the Timer trigger from "All Players" to "Player 8" (assuming player 8 is a computer player).
Post has been edited 1 time(s), last time on Aug 6 2011, 5:13 am by Roy.
Learn how EUDs work: A Mapmaker's Guide for Creating EUDs
Don't like learning?: EUDGen 2
Other stuff: Farlap Bound Maker
Dash: 1 2 3 4 5 6 7 8 9 X
Jog: Original Warp
Other: Super Mario SC Fireball Guard Your Civilian Strength Contest
Don't like learning?: EUDGen 2
Other stuff: Farlap Bound Maker
Dash: 1 2 3 4 5 6 7 8 9 X
Jog: Original Warp
Other: Super Mario SC Fireball Guard Your Civilian Strength Contest
Quote from Roy
RoyThe issue is that you are resetting the timer under "All Players." If you understand how trigger order works, you'd see the problem with this.
Player 1's refinery trigger runs, and then Player 1 also runs the trigger to reset the timer. Since the timer is no longer at 0, players 2-6 do not get their refinery trigger to execute.
Chang the owner of the Timer trigger from "All Players" to "Player 8" (assuming player 8 is a computer player).
Player 1's refinery trigger runs, and then Player 1 also runs the trigger to reset the timer. Since the timer is no longer at 0, players 2-6 do not get their refinery trigger to execute.
Chang the owner of the Timer trigger from "All Players" to "Player 8" (assuming player 8 is a computer player).
Okay, thanks. This makes a lot of sense now. Hopefully I won't run into any more problems
Quote from 
Aristocrat
AristocratAside from that I see no actual problems with the trigger itself. Are you sure that players 2-6 actually own refineries when the countdown timer reaches 0?
I originally had them all grouped together like that, but for some reason I thought that might be a problem so I split them apart to see if it would change anything
None.
I highly recommend reading through this article:
http://www.staredit.net/starcraft/Triggers
Very informative on how sc1 triggers work.
http://www.staredit.net/starcraft/Triggers
Very informative on how sc1 triggers work.
None.
Options
Pages: 1
Back to forum
Please log in to reply to this topic or to report it.
Members in this topic: None.
[03:57 am]
NudeRaider -- https://staredit.net/381600/ You have 5 minutes, then you can only edit your posts.
[2026-4-14. : 12:07 am]
Vrael -- NudeRaiderNudeRaider shouted: Vrael ranting still is though
you're a gentleman and a scholar, thank you
Members Online: anoeth47